Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

autoSkipNonRecoverableData config in broker.conf does not work #6841

Closed
pheecian opened this issue Apr 29, 2020 · 0 comments · Fixed by #6863
Closed

autoSkipNonRecoverableData config in broker.conf does not work #6841

pheecian opened this issue Apr 29, 2020 · 0 comments · Fixed by #6863
Labels
type/bug The PR fixed a bug or issue reported a bug

Comments

@pheecian
Copy link
Contributor

Describe the bug
A clear and concise description of what the bug is.
when reading data from pulsar, if autoSkipNonRecoverableData is set, then the reading process will not block due to certain NonRecoverableLedgerException. However, when use Reader API and use seek(timestamp) method, this configuration takes no effect.
To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.
Seek should not fail due to certain NonRecoverableLedgerException

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]

Additional context
Add any other context about the problem here.
@pheecian pheecian added the type/bug The PR fixed a bug or issue reported a bug label Apr 29, 2020
@sijie sijie mentioned this issue Apr 29, 2020
Closed
@pheecian pheecian changed the title autoSkipNonRecoverableData does not work when use reader.seek autoSkipNonRecoverableData config in broker.conf does not work May 2, 2020
@pheecian pheecian mentioned this issue May 2, 2020
Merged
1 task
jiazhai pushed a commit that referenced this issue May 12, 2020
@pheecian
fix autoSkipConf (#6863)
3198f4f 
Fixes #6841
Co-authored-by: Xiaopeng Zhang <xiaopengzhang@Xiaopengs-MacBook-Pro.local>
Co-authored-by: Jia Zhai <zhaijia@apache.org>
jiazhai pushed a commit that referenced this issue May 12, 2020
@pheecian @jiazhai
fix autoSkipConf (#6863)
2dae2b5 
Fixes #6841
Co-authored-by: Xiaopeng Zhang <xiaopengzhang@Xiaopengs-MacBook-Pro.local>
Co-authored-by: Jia Zhai <zhaijia@apache.org>
(cherry picked from commit 3198f4f)
Huanli-Meng pushed a commit to Huanli-Meng/pulsar that referenced this issue May 27, 2020
@pheecian @Huanli-Meng
fix autoSkipConf (apache#6863)
c5e30cd 
Fixes apache#6841
Co-authored-by: Xiaopeng Zhang <xiaopengzhang@Xiaopengs-MacBook-Pro.local>
Co-authored-by: Jia Zhai <zhaijia@apache.org>
addisonj pushed a commit to instructure/pulsar that referenced this issue Jun 12, 2020
@pheecian
fix autoSkipConf (apache#6863)
cc10503 
Fixes apache#6841
Co-authored-by: Xiaopeng Zhang <xiaopengzhang@Xiaopengs-MacBook-Pro.local>
Co-authored-by: Jia Zhai <zhaijia@apache.org>
(cherry picked from commit 3198f4f)
huangdx0726 pushed a commit to huangdx0726/pulsar that referenced this issue Aug 24, 2020
@pheecian @huangdx0726
fix autoSkipConf (apache#6863)
f0b6915 
Fixes apache#6841
Co-authored-by: Xiaopeng Zhang <xiaopengzhang@Xiaopengs-MacBook-Pro.local>
Co-authored-by: Jia Zhai <zhaijia@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Issue #6841]fix autoSkipConf pheecian/pulsar
2 participants
@sijie @pheecian