Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose topic/subscription/consumer number of messages as counter. #6891

Closed
one1zero1one opened this issue May 6, 2020 · 1 comment · Fixed by #6918
Closed

Expose topic/subscription/consumer number of messages as counter. #6891

one1zero1one opened this issue May 6, 2020 · 1 comment · Fixed by #6918
Labels
area/broker type/feature The PR added a new feature or issue requested a new feature

Comments

@one1zero1one
Copy link

Is your feature request related to a problem? Please describe.
Topic metrics are expressed as computed rates, e.g. gauges: pulsar_rate_in pulsar_rate_out. This makes Prometheus scraping miss any change of rate in between the scrape interval.

Describe the solution you'd like
Exposing the metrics as counters instead/in addition to gauges, e.g. pulsar_count_in would allow the rate to be computed in prometheus, and would not miss change of rates within the scraping interval.

Describe alternatives you've considered
Increasing the scrape interval to <15s however it still misses spikes.
I have considered using a sidecar container that would create the counters from gauges, but it adds unwanted complexity.
@one1zero1one one1zero1one added the type/feature The PR added a new feature or issue requested a new feature label May 6, 2020
@sijie sijie mentioned this issue May 6, 2020
Closed
@sijie
Copy link
Member

sijie commented May 7, 2020

@one1zero1one I think @PierreZ already added this feature. We will check if it will be released as part of 2.6.0.

@codelipenghui codelipenghui mentioned this issue May 8, 2020
Merged
sijie pushed a commit that referenced this issue May 8, 2020
@codelipenghui
Expose pulsar_out_bytes_total and pulsar_out_messages_total for names…
204f327 
…pace/subscription/consumer. (#6918)

Fixes #6891
Rated to #5802
### Motivation

Add pulsar_out_bytes_total and pulsar_out_messages_total for namespace/subscription/consumer.

### Verifying this change

New unit test added.
jiazhai pushed a commit that referenced this issue May 12, 2020
@codelipenghui @jiazhai
Expose pulsar_out_bytes_total and pulsar_out_messages_total for names…
9c5644b 
…pace/subscription/consumer. (#6918)

Fixes #6891
Rated to #5802

Add pulsar_out_bytes_total and pulsar_out_messages_total for namespace/subscription/consumer.

New unit test added.
(cherry picked from commit 204f327)
cdbartholomew pushed a commit to kafkaesque-io/pulsar that referenced this issue May 23, 2020
@codelipenghui @cdbartholomew
Expose pulsar_out_bytes_total and pulsar_out_messages_total for names…
ebfb361 
…pace/subscription/consumer. (apache#6918)

Fixes apache#6891
Rated to apache#5802

Add pulsar_out_bytes_total and pulsar_out_messages_total for namespace/subscription/consumer.

New unit test added.
Huanli-Meng pushed a commit to Huanli-Meng/pulsar that referenced this issue May 27, 2020
@codelipenghui @Huanli-Meng
Expose pulsar_out_bytes_total and pulsar_out_messages_total for names…
71adae1 
…pace/subscription/consumer. (apache#6918)

Fixes apache#6891
Rated to apache#5802
### Motivation

Add pulsar_out_bytes_total and pulsar_out_messages_total for namespace/subscription/consumer.

### Verifying this change

New unit test added.
addisonj pushed a commit to instructure/pulsar that referenced this issue Jun 12, 2020
@codelipenghui
Expose pulsar_out_bytes_total and pulsar_out_messages_total for names…
06815c8 
…pace/subscription/consumer. (apache#6918)

Fixes apache#6891
Rated to apache#5802

Add pulsar_out_bytes_total and pulsar_out_messages_total for namespace/subscription/consumer.

New unit test added.
(cherry picked from commit 204f327)
huangdx0726 pushed a commit to huangdx0726/pulsar that referenced this issue Aug 24, 2020
@codelipenghui @huangdx0726
Expose pulsar_out_bytes_total and pulsar_out_messages_total for names…
a59bcea 
…pace/subscription/consumer. (apache#6918)

Fixes apache#6891
Rated to apache#5802
### Motivation

Add pulsar_out_bytes_total and pulsar_out_messages_total for namespace/subscription/consumer.

### Verifying this change

New unit test added.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/broker type/feature The PR added a new feature or issue requested a new feature
Projects
None yet
Milestone
No milestone
2 participants
@one1zero1one @sijie