[C++] Fix segfault when get topic name from received message id #10006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codelipenghui
approved these changes
Mar 22, 2021
codelipenghui
requested review from
315157973,
hangc0276,
jiazhai,
merlimat,
sijie and
zymap
|
/pulsarbot run-failure-checks |
merlimat
approved these changes
Mar 22, 2021
codelipenghui
pushed a commit
that referenced
this pull request
Mar 24, 2021
* Fix segfault when get topic name from received message id * Add tests for non-batched message (cherry picked from commit 74c694f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently C++ client support get topic name from both received message and its message id. However, for a consumer that subscribes a non-partitioned topic, getting topic name from received message id will cause segmentation fault.
The C++ implementation of
Message::getTopicNameorMessageId::getTopicNamerequires the invocation ofMessage::setTopicName, which make the internalstd::string*point to the topic string of the consumer. IfsetTopicNamewas not called, thegetTopicNamemethod would cause segmentation fault since a null pointer would be dereferenced.However, when the consumer creates single messages from the batched message,
setTopicNamewas not called.Modifications
setTopicNamefor each single message when a consumer receives a batch.Consumer, includingConsumerImpl,MultiTopicsConsumerImplandPartitionedConsumerImpl.Verifying this change
This change added tests
ConsumerTest.testGetTopicNameFromReceivedMessage.