Support set property on a namespace. #10015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codelipenghui
requested review from
hangc0276,
315157973,
sijie,
jiazhai,
merlimat,
zymap and
eolivelli
zymap
reviewed
Mar 23, 2021
| try { | ||
| final String path = path(POLICIES, namespaceName.toString()); | ||
| updatePolicies(path, (policies) -> { | ||
| policies.properties.put(key, value); |
There was a problem hiding this comment.
Do we need to provide an option for overwriting the existing key?
There was a problem hiding this comment.
Overwriting the existing key is the default behavior. If we need to support prevent an update when the key exists, we can add it in the future.
315157973
reviewed
Mar 26, 2021
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java
Outdated
Show resolved
Hide resolved
315157973
approved these changes
Mar 26, 2021
|
/pulsarbot run-failure-checks |
sijie
reviewed
Mar 30, 2021
There was a problem hiding this comment.
@codelipenghui overall looks good. but it might be worth supporting set a map of key/value pairs together instead of individual keys.
|
@sijie Make sense, will add an endpoint to support multiple key-values. |
sijie
approved these changes
Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Add support for set-property/get-property/remove-property on a namespace
Modifications
bin/pulsar-admin namespaces set-property
bin/pulsar-admin namespaces get-property
bin/pulsar-admin namespaces remove-property
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
The document is generated automatically.