[pulsar-websocket] Allow websocket to consume and pass message to client without decryption #10026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent without decryption
rdhabalia
requested review from
merlimat,
sijie,
jiazhai,
codelipenghui and
nkurihar
Closed
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
sijie
approved these changes
Mar 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Right now, websocket proxy fails to receive and send message to client-consumer if message is encrypted. Websocket proxy should default pass encrypted message to client without decrypting and let client app handles it. So, add default decryption action as :
CONSUME. I will create a separate PR to support decryption at websocket proxy in specific scenario where user wants websocket to handle message decryption.