-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pulsar IO: Allow to develop Sinks that support Schema but without setting it at build time (Sink<GenericObject>) #10034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eolivelli
changed the title
Pulsar IO: Allow develop Sinks that support Schema but without setting it at build time (Sink<Object>)
Pulsar IO: Allow to develop Sinks that support Schema but without setting it at build time (Sink<Object>)
Mar 24, 2021
eolivelli
changed the title
Pulsar IO: Allow to develop Sinks that support Schema but without setting it at build time (Sink<Object>)
Pulsar IO: Allow to develop Sinks that support Schema but without setting it at build time (Sink<GenericObject>)
Mar 30, 2021
…ting it at build time (Sink<GenericObject>)
eolivelli
force-pushed
the
impl/sink-object
branch
from
April 8, 2021 07:07
8224eb8
to
3bbf7aa
Compare
eolivelli
added
area/connector
component/schemaregistry
type/feature
The PR added a new feature or issue requested a new feature
labels
Apr 8, 2021
codelipenghui
requested changes
Apr 9, 2021
@codelipenghui I have reverted the conf file. |
@codelipenghui @jerrypeng CI finally passed |
codelipenghui
approved these changes
Apr 11, 2021
eolivelli
added a commit
to datastax/pulsar
that referenced
this pull request
May 12, 2021
…ting it at build time (Sink<GenericObject>) (apache#10034) (cherry picked from commit 42e92a7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Support users that want to implement a Sink that is aware of the Schema but it is not tied to a specific schema type at compile time.
With this patch you can implement a Sink that is aware of the Schema but it is not tied to a particular schema type at compile time.
Modifications
We are adding support in TopicSchema.java to deal with GenericObject, the same way we did with GenericRecord. GenericRecord is a subtype of GenericObject, and AutoConsumeSchema now returns GenericObject instances that wrap primitive data types
Verifying this change
I will add test cases and integration tests as soon as the community accepts this feature.
Does this pull request potentially affect one of the following parts:
With this feature Sink developers will be able to write advanced Sinks
Documentation
I will be happy to provide documentation as soon as this feature lands to Pulsar