Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[websocket] support pong in websocket #10035

Merged
merged 4 commits into from
Mar 26, 2021
Merged

[websocket] support pong in websocket #10035

merged 4 commits into from
Mar 26, 2021

Conversation

linlinnn
Copy link
Contributor

@linlinnn linlinnn commented Mar 24, 2021 •
edited
Loading

Fixes #10014

Motivation

Add "pong" logic in websocket server

Modifications

add WebSocketPingPongServlet to apply "pong" when on ping

Verifying this change

  • Make sure that the change passes the CI checks.

codelipenghui
codelipenghui reviewed Mar 25, 2021
View reviewed changes
Copy link
Contributor

@codelipenghui codelipenghui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, could you please help add some test for this change?

@codelipenghui codelipenghui added this to the 2.8.0 milestone Mar 25, 2021
@linlinnn
Copy link
Contributor Author

@codelipenghui PTAL

315157973
315157973 approved these changes Mar 25, 2021
View reviewed changes
Copy link
Contributor

@315157973 315157973 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@linlinnn
Copy link
Contributor Author

/pulsarbot run-failure-checks

@codelipenghui codelipenghui merged commit 60081af into apache:master Mar 26, 2021
@youzipi
Copy link
Contributor

youzipi commented Feb 25, 2022 •
edited
Loading

websocket producer and websocket pingpong has different url,
how can i use this to make a heartbeat to keep connection alive?
@linlinnn

@michaeljmarshall michaeljmarshall mentioned this pull request Jul 6, 2023
Merged
1 task
@michaeljmarshall
Copy link
Member

websocket producer and websocket pingpong has different url, how can i use this to make a heartbeat to keep connection alive? @linlinnn

Please see @lhotari's comment for more information #10014 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sijie sijie sijie approved these changes

@315157973 315157973 315157973 approved these changes

@codelipenghui codelipenghui codelipenghui approved these changes

@eolivelli eolivelli Awaiting requested review from eolivelli

@zymap zymap Awaiting requested review from zymap

@hangc0276 hangc0276 Awaiting requested review from hangc0276

@jiazhai jiazhai Awaiting requested review from jiazhai

@merlimat merlimat Awaiting requested review from merlimat

Assignees

@linlinnn linlinnn

Labels
area/websocket
Projects
None yet
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.

Add "pong" logic in websocket server
6 participants
@linlinnn @youzipi @michaeljmarshall @sijie @315157973 @codelipenghui