Add jersey-client as dependency of pulsar-client-auth-sasl

[BewareMyPower]

Motivation

When using AuthenticationSasl, ClassNotFoundException will be thrown:

Exception in thread "main" java.lang.RuntimeException: java.lang.ClassNotFoundException: org.glassfish.jersey.client.JerseyClientBuilder

The jersey-client dependency must be imported. However the version of jersey-client must be consistent with what pulsar-client-auth-sasl depends, which is 2.31 currently. For example, if a newer version of jersey-client was imported like

    <dependency>
      <groupId>org.glassfish.jersey.core</groupId>
      <artifactId>jersey-client</artifactId>
      <version>3.0.1</version>
    </dependency>

Another exception would be thrown:

Exception in thread "main" java.lang.NoClassDefFoundError: jakarta/ws/rs/client/ClientBuilder

So the best way to fix it is adding jersey-client as dependency of pulsar-client-auth-sasl.

Modifications

Add jersey-client as dependency of pulsar-client-auth-sasl.

Verifying this change

• Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.

[eolivelli]

Why are we able to build that module without adding the dependency?
Isn't it already imported implicitly?

[BewareMyPower]

@eolivelli

Here's the completed exception stack.

Exception in thread "main" java.lang.RuntimeException: java.lang.ClassNotFoundException: org.glassfish.jersey.client.JerseyClientBuilder
	at javax.ws.rs.client.ClientBuilder.newBuilder(ClientBuilder.java:110)
	at javax.ws.rs.client.ClientBuilder.newClient(ClientBuilder.java:121)
	at org.apache.pulsar.client.impl.auth.AuthenticationSasl.start(AuthenticationSasl.java:164)
	at org.apache.pulsar.client.impl.PulsarClientImpl.<init>(PulsarClientImpl.java:146)
	at org.apache.pulsar.client.impl.PulsarClientImpl.<init>(PulsarClientImpl.java:134)
	at org.apache.pulsar.client.impl.PulsarClientImpl.<init>(PulsarClientImpl.java:130)
	at org.apache.pulsar.client.impl.ClientBuilderImpl.build(ClientBuilderImpl.java:65)
	at pulsar.KerberosAuthClient.main(KerberosAuthClient.java:27)

From javax.ws.rs.client.ClientBuilder.newBuilder we can see

    public static ClientBuilder newBuilder() {
        try {
            Object delegate = FactoryFinder.find("javax.ws.rs.client.ClientBuilder", "org.glassfish.jersey.client.JerseyClientBuilder", ClientBuilder.class);
            if (!(delegate instanceof ClientBuilder)) {
                Class pClass = ClientBuilder.class;
                String classnameAsResource = pClass.getName().replace('.', '/') + ".class";
                ClassLoader loader = pClass.getClassLoader();
                if (loader == null) {
                    loader = ClassLoader.getSystemClassLoader();
                }

It tries to load JerseyClientBuilder dynamically.

[eolivelli]

Do we have test case? Why the tests are not failing?

[BewareMyPower]

Maybe it's because the tests uses the jersey-client dependency from the root pom.xml.

pulsar/pom.xml

Lines 604 to 608 in 1b8da92

	<dependency>
	<groupId>org.glassfish.jersey.core</groupId>
	<artifactId>jersey-client</artifactId>
	<version>${jersey.version}</version>
	</dependency>

I'm not very familiar to Maven and not sure if it could be loaded by sub-module implicitly in tests.

[eolivelli]

Lgtm

Btw it is better to have the explicit dependency here.

I was just asking those questions in order to understand better the problem

[BewareMyPower]

/pulsarbot run-failure-checks