Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Schema.getNativeSchema #10076

Merged
merged 1 commit into from
Apr 1, 2021
Merged

Conversation

eolivelli
Copy link
Contributor

Fixes #10075

Motivation

We need a way to access the native schema, in order to have detailed metadata.

The alternative is currently to parse again the schema definition, but this is not efficient.

Modifications

Add a new method Optional<Object> Schema#getNativeSchema and implement it for AVRO, JSON and Protobuf

Verifying this change

This change added tests

Documentation

  • Does this pull request introduce a new feature? yes
  • If yes, how is the feature documented? JavaDocs

@eolivelli eolivelli requested review from sijie, codelipenghui and congbobo184 and removed request for sijie and codelipenghui March 30, 2021 09:19
@eolivelli eolivelli marked this pull request as ready for review March 30, 2021 09:19
@eolivelli
Copy link
Contributor Author

@codelipenghui @sijie do you have any comments about this feature ?

@eolivelli eolivelli self-assigned this Mar 31, 2021
@codelipenghui codelipenghui added this to the 2.8.0 milestone Mar 31, 2021
@eolivelli eolivelli merged commit 4128151 into apache:master Apr 1, 2021
@eolivelli eolivelli deleted the impl/native-schema branch April 1, 2021 15:34
eolivelli added a commit to datastax/pulsar that referenced this pull request May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Schema API: add a way to access the Native Schema
2 participants