Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GenericObject - support KeyValue in Message#getValue() #10107

Merged
merged 23 commits into from Apr 9, 2021

Conversation

eolivelli
Copy link
Contributor

@eolivelli eolivelli commented Mar 31, 2021

Basically with this patch we are supporting KeyValue on Message.getValue() when using AutoConsumeSchema.

Modifications:

  • enhance KeyValue handling in MessageImpl.java
  • add a test case about reading a KeyValue payload with Schema.AUTO_CONSUME()

@eolivelli eolivelli self-assigned this Mar 31, 2021
@eolivelli eolivelli marked this pull request as ready for review April 8, 2021 06:50
@eolivelli eolivelli requested a review from merlimat April 8, 2021 16:01
@eolivelli eolivelli changed the title GenericObject - support KeyValue GenericObject - support KeyValue in Message#getValue() Apr 8, 2021
@codelipenghui codelipenghui added this to the 2.8.0 milestone Apr 9, 2021
@eolivelli eolivelli merged commit a5a94ed into apache:master Apr 9, 2021
@eolivelli eolivelli deleted the fix/object-keyvalue branch April 9, 2021 17:29
eolivelli added a commit to datastax/pulsar that referenced this pull request May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants