Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support set namespace and topic policy for non-persistent dispatcher #10121

Merged
merged 1 commit into from
Apr 8, 2021

Conversation

315157973
Copy link
Contributor

Motivation

maxConsumerPerSubscription in NonPersistentDispatcherMultipleConsumers only support broker-level policies

Modifications

Make it support namespace and topic level policies

Verifying this change

@sijie sijie added this to the 2.8.0 milestone Apr 1, 2021
@codelipenghui codelipenghui merged commit 9c17ee8 into apache:master Apr 8, 2021
wangjialing218 pushed a commit to wangjialing218/pulsar that referenced this pull request Apr 9, 2021
…pache#10121)

### Motivation
maxConsumerPerSubscription in NonPersistentDispatcherMultipleConsumers only support broker-level policies

### Modifications
Make it support namespace and topic level policies

### Verifying this change
@eolivelli
Copy link
Contributor

@315157973 this patch does not apply to branch-7.2.
Do you mind sending a PR against branch-7.2 ?
this way we can deliver this fix in 2.7.2

@codelipenghui
Copy link
Contributor

This PR depends on #10061, we need to cherry-pick #10061 first.

@eolivelli
Copy link
Contributor

I would like to not cherry pick #10061 it looks to me that it is better not to introduce now refactor, now that we are close to the release
@codelipenghui

@315157973
Copy link
Contributor Author

I would like to not cherry pick #10061 it looks to me that it is better not to introduce now refactor, now that we are close to the release
@codelipenghui

There is a relationship between them. If we want to cherry-pick, we need to pick both of them.

@315157973 315157973 deleted the max-consumer branch May 11, 2021 09:02
@tisonkun
Copy link
Member

Hi @codelipenghui @eolivelli ! Recently I see a cherry-pick command added into pulsar bot a few months ago. I'm curious whether or not it is still in use.

https://github.com/apache/pulsar-test-infra/blob/master/cherry-pick/entrypoint.sh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants