Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GenericObject: handle KeyValue with SEPARATED encoding and add more tests #10186

Merged

Conversation

eolivelli
Copy link
Contributor

Motivations:
When you are using SEPARATED KeyEncoding Message#getValue() must return a GenericObject wrapper, before this patch it returned a raw KeyValue, leading to a ClassCastException on the Consumer.

Modifications:

  • handle KeyValue with SEPARATED key encoding in MessageImpl
  • add more test about GenericObject + KeyValue: INLINE/SEPARATED, primitives/structs

@eolivelli
Copy link
Contributor Author

/pulsarbot rerun-failure-checks

@codelipenghui codelipenghui added this to the 2.8.0 milestone Apr 12, 2021
@eolivelli eolivelli merged commit 7d04a79 into apache:master Apr 12, 2021
eolivelli added a commit to datastax/pulsar that referenced this pull request May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants