[Broker] Close namespace clients when PulsarService is closed #10196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eolivelli
requested changes
Apr 12, 2021
pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/NamespaceService.java
Outdated
Show resolved
Hide resolved
lhotari
force-pushed
the
lh-close-namespace-clients
branch
from
abce9dc
to
2eeda6a
Compare
merlimat
approved these changes
Apr 12, 2021
sijie
approved these changes
Apr 13, 2021
lhotari
force-pushed
the
lh-close-namespace-clients
branch
from
2eeda6a
to
a555d12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The broker leaks some PulsarClient instances since the PulsarClient instances created in NamespaceService don't get closed.
Modifications
Add handling for closing PulsarClient instances created in NamespaceService. A similar logic for closing is used as there is currently for closing the PulsarClients of replication clients.