Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shutdown Broker gracefully, but forcefully after brokerShutdownTimeoutMs #10199

Merged
merged 17 commits into from
Apr 16, 2021
Merged

Shutdown Broker gracefully, but forcefully after brokerShutdownTimeoutMs #10199

merged 17 commits into from
Apr 16, 2021

Commits on Apr 16, 2021

  1. Wait for shutdown of BrokerService event loops

    @lhotari
    lhotari committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    669b548 View commit details
    Browse the repository at this point in the history

  2. Move CompletableFutureCancellationHandler to pulsar-common util

    @lhotari
    lhotari committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    d77e266 View commit details
    Browse the repository at this point in the history

  3. Prevent misusage of CompletableFutureCancellationHandler

    @lhotari
    lhotari committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    40f7bde View commit details
    Browse the repository at this point in the history

  4. Clear cancelAction field after the future completes 

    - make cancelAction eligible for GC after the future completes (or
  gets cancelled)
    @lhotari
    lhotari committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    321ccf8 View commit details
    Browse the repository at this point in the history

  5. Support cancel signalling when executing multiple futures

    @lhotari
    lhotari committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    7203920 View commit details
    Browse the repository at this point in the history

  6. Shutdown BrokerService gracefully which using closeAsync 

    - shutdown forcefully when closing times out
    @lhotari
    lhotari committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    3ffe19a View commit details
    Browse the repository at this point in the history

  7. Set 100ms to brokerShutdownTimeoutMs used in tests

    @lhotari
    lhotari committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    f83f318 View commit details
    Browse the repository at this point in the history

  8. Revert changes in MessagingServiceShutdownHook

    @lhotari
    lhotari committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    f6aa6b3 View commit details
    Browse the repository at this point in the history

  9. Handle CancellationException since it's used in timeouts in BrokerSer… 

    …vice
    @lhotari
    lhotari committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    5b4574a View commit details
    Browse the repository at this point in the history

  10. Set shutdown timeout to 0 ms in tests

    @lhotari
    lhotari committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    7a9cf0b View commit details
    Browse the repository at this point in the history

  11. Ignore TimeoutException and CancellationException when broker shutdow… 

    …n timeout is 0
    @lhotari
    lhotari committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    6cefd7f View commit details
    Browse the repository at this point in the history

  12. Extract GracefulExecutorServicesShutdown and use it in PulsarService 

    - handle graceful / forcefully shutdown also for PulsarService executors
    @lhotari
    lhotari committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    833b866 View commit details
    Browse the repository at this point in the history

  13. Fix some unclosed PulsarServices

    @lhotari
    lhotari committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    fe5433e View commit details
    Browse the repository at this point in the history

  14. Set shutdown timeout to 0 in some more tests

    @lhotari
    lhotari committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    cc38f9e View commit details
    Browse the repository at this point in the history

  15. Do some class and method renamings to clarify the code

    @lhotari
    lhotari committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    9cc5212 View commit details
    Browse the repository at this point in the history

  16. Revisit the logic to use awaitTermination

    @lhotari
    lhotari committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    92b3895 View commit details
    Browse the repository at this point in the history

  17. Use shutdownNow to shutdown the scheduler used for future timeout han… 

    …dling
    @lhotari
    lhotari committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    e4ad678 View commit details
    Browse the repository at this point in the history