[PIP-82] [pulsar-broker] CRUD support for ResourceGroup #10218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/pulsarbot run-failure-checks |
4 similar comments
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
|
@merlimat Could you take a look at this PR when you get a chance, in the meantime i will continue to try re-running the tests to get a pass. Thanks. |
ravi-vaidyanathan
force-pushed
the
resourcegroup-crud-support
branch
from
dcbb1aa
to
de29420
Compare
|
/pulsarbot run-failure-checks |
merlimat
reviewed
Apr 16, 2021
| @@ -101,6 +104,13 @@ public Policies deserialize(String path, byte[] content) throws Exception { | |||
| } | |||
| }; | |||
|
|
|||
| this.resourcegroupsCache = new ZooKeeperDataCache<ResourceGroup>(cache) { | |||
There was a problem hiding this comment.
Since we're moving towards having all accesses through the metadata store API, is there a way to avoid this?
There was a problem hiding this comment.
Thanks for catching this, removed it.
merlimat
reviewed
Apr 16, 2021
|
|
||
| import java.util.Objects; | ||
|
|
||
| public class ResourceGroup { |
There was a problem hiding this comment.
We can use @Data annotation from Lombok to automatically generate the constructors, hashcode, equals and toString methods. (and mark the fields as private)
merlimat
approved these changes
Apr 16, 2021
merlimat
added
the
type/feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
PIP-82 adds support for distributed resource quota enforcement at a tenant, namespace or topic level.
Modifications
Verifying this change
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation