Fix entry cache size update logic so it won't go negative. #10225
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10016
Motivation
Metrics
pulsar_ml_cache_used_size
can to negative sometime.Modifications
Only place where we could subtract more from the cache size then we add to it is when an EntryCache is cleared, the returned value is not the size of entries removed but the size of cache before clear(). Update the behavior here to return the size of entries removed.
Verifying this change
Added unit test.