Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue 9204][Python/C++]Expose replicateSubscriptionState setting for python/c++ consumer #10243

Merged
merged 4 commits into from
May 22, 2021

Conversation

RobertIndie
Copy link
Member

@RobertIndie RobertIndie commented Apr 15, 2021

Fixes #9204

Motivation

Currently, in the python and C++ client, the "replicateSubscriptionState" feature can no be enabled in the consumer creation.

Modifications

Expose the "replicateSubscriptionState" setting in the consumer's construct function.

@codelipenghui codelipenghui added release/2.7.2 type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages labels Apr 15, 2021
@codelipenghui codelipenghui added this to the 2.8.0 milestone Apr 15, 2021
@codelipenghui
Copy link
Contributor

@BewareMyPower Please help review this PR

@RobertIndie
Copy link
Member Author

/pulsarbot run-failure-checks

@RobertIndie
Copy link
Member Author

/pulsarbot run-failure-checks

@RobertIndie
Copy link
Member Author

/pulsarbot run-failure-checks

@codelipenghui codelipenghui merged commit 67adf0a into apache:master May 22, 2021
yangl pushed a commit to yangl/pulsar that referenced this pull request Jun 23, 2021
… python/c++ consumer (apache#10243)

Fixes apache#9204

### Motivation

Currently, in the python and C++ client, the "replicateSubscriptionState" feature can no be enabled in the consumer creation.

### Modifications

Expose the "replicateSubscriptionState" setting in the consumer's construct function.
@liguangcheng
Copy link

liguangcheng commented Dec 1, 2021

Hi all

I see the replicateSubscriptionState setting has been exposed in C++ client at version 2.8, have you test if it is work among multi cluster?

bharanic-dev pushed a commit to bharanic-dev/pulsar that referenced this pull request Mar 18, 2022
… python/c++ consumer (apache#10243)

Fixes apache#9204

### Motivation

Currently, in the python and C++ client, the "replicateSubscriptionState" feature can no be enabled in the consumer creation.

### Modifications

Expose the "replicateSubscriptionState" setting in the consumer's construct function.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Python Client] Expose "replicateSubscriptionState" setting for python consumer
8 participants