[Cursor] add return statement to exit asyncMarkDelete early on failure #10272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sijie
approved these changes
Apr 20, 2021
sijie
requested review from
315157973,
codelipenghui,
hangc0276,
jiazhai and
merlimat
sijie
added
component/storage
release/2.7.2
type/bug
merlimat
approved these changes
Apr 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In reading through the message expiration code, I noticed that there is a case where we call
markDeleteFailedon a callback, but don't subsequently return from the method.For background, any other time we call the
markDeleteFailedmethod, we either call return or exit the method because it is part of a callback.Verifying this change
None. I think this change is obvious enough that it doesn't require any validation. Please let me know if more validation is required.