Improve localrun performance by using JVM options more suited for it #10273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srkukarni
approved these changes
Apr 20, 2021
sijie
approved these changes
Apr 20, 2021
ivankelly
pushed a commit
to ivankelly/pulsar
that referenced
this pull request
Aug 10, 2021
…pache#10273) ### Motivation Currently, the JVM options used for localrun are the same as that used for the pulsar-admin tool. The JVM options used are suited for CLI tools that need a short startup time. Sinkce localrun is a long running process, we can achieve better performance especially in GC if we use JVM options more suited for this kind of workload. I am seeing around 20% better performance with these changes in JVM options.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, the JVM options used for localrun are the same as that used for the pulsar-admin tool. The JVM options used are suited for CLI tools that need a short startup time. Sinkce localrun is a long running process, we can achieve better performance especially in GC if we use JVM options more suited for this kind of workload. I am seeing around 20% better performance with these changes in JVM options.