[Issue 8214][pulsar-client] Added pausing of new topic consumers to MultiTopicsConsumerImpl. #10305
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8214
Motivation
A new consumer can be added to the
MultiTopicsConsumerImpl
in one of two ways:subscribeAsync(String topicName, boolean createTopicIfDoesNotExist)
method manually.subscribeIncreasedTopicPartitions(String topicName)
).Currently, only the second way ensures that the newly added consumers are paused if the parent consumer is paused. The first way will never result in pausing the newly added consumers.
Moreover, the unit test for the second way is not strict enough. If we modify the
subscribeIncreasedTopicPartitions(String topicName)
method not to pause the newly created consumers, the unit test still passes. Unit test method:SimpleProducerConsumerTest#testMultiTopicsConsumerImplPause()
.Modifications
subscribeAsync(String topicName, boolean createTopicIfDoesNotExist)
method. The logic is the same as the existing logic in thesubscribeIncreasedTopicPartitions(String topicName)
method.SimpleProducerConsumerTest#testMultiTopicsConsumerImplPause()
test method, as it was too lenient. It has been renamed toSimpleProducerConsumerTest#testMultiTopicsConsumerImplPauseForPartitionNumberChange()
Verifying this change
This change added tests and can be verified as follows:
SimpleProducerConsumerTest#testMultiTopicsConsumerImplPauseForManualSubscription()
unit test method.Does this pull request potentially affect one of the following parts:
No.
Documentation
- If yes, how is the feature documented? not applicable- If a feature is not applicable for documentation, explain why?- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation