Fix the inconsistency of AdvertisedAddress #10312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eolivelli
requested changes
Apr 22, 2021
sijie
requested review from
congbobo184,
gaoran10,
hangc0276,
jiazhai and
merlimat
|
@codelipenghui @jiazhai @eolivelli PTAL again. thanks. |
|
Now this bug will cause advertisedListeners to be set but invalid, because some places still get advertisedAddress |
|
ping @eolivelli Can you help review this change again. |
eolivelli
requested changes
May 7, 2021
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
Outdated
Show resolved
Hide resolved
codelipenghui
approved these changes
May 10, 2021
eolivelli
pushed a commit
to eolivelli/pulsar
that referenced
this pull request
May 11, 2021
### Motivation There is an `advertisedAddress` in PusarService and an `advertisedAddress` in conf. When `advertisedListener` is set, the values of the two `advertisedAddress` will be inconsistent. In the current code, `PusarService.getAdvertisedAddress` is used in some places, and `conf.getAdvertisedAddress` is used in other places. ### Modifications Put this logic into the config to keep the values in all places consistent.
codelipenghui
pushed a commit
that referenced
this pull request
Jun 26, 2021
There is an `advertisedAddress` in PusarService and an `advertisedAddress` in conf. When `advertisedListener` is set, the values of the two `advertisedAddress` will be inconsistent. In the current code, `PusarService.getAdvertisedAddress` is used in some places, and `conf.getAdvertisedAddress` is used in other places. Put this logic into the config to keep the values in all places consistent. (cherry picked from commit d39e5e4)
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There is an
advertisedAddressin PusarService and anadvertisedAddressin conf. WhenadvertisedListeneris set, the values of the twoadvertisedAddresswill be inconsistent.In the current code,
PusarService.getAdvertisedAddressis used in some places, andconf.getAdvertisedAddressis used in other places.Modifications
Put this logic into the config to keep the values in all places consistent.
Verifying this change