-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Transaction] Fix MLTransactionLog open manageLedger name problem. #10334
[Transaction] Fix MLTransactionLog open manageLedger name problem. #10334
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome.
I left some minor comments
@@ -302,7 +303,8 @@ public PersistentTopic(String topic, ManagedLedger ledger, BrokerService brokerS | |||
|
|||
if (brokerService.getPulsar().getConfiguration().isTransactionCoordinatorEnabled() | |||
&& !checkTopicIsEventsNames(topic) | |||
&& !topic.contains(TopicName.TRANSACTION_COORDINATOR_ASSIGN.getLocalName())) { | |||
&& !topic.contains(TopicName.TRANSACTION_COORDINATOR_ASSIGN.getLocalName()) | |||
&& !topic.contains(MLTransactionLogImpl.TRANSACTION_LOG_PREFIX)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use startsWith
?
managedLedgerConfig.setMaxEntriesPerLedger(2); | ||
new MLTransactionLogImpl(TransactionCoordinatorID.get(0), | ||
pulsar.getManagedLedgerFactory(), managedLedgerConfig); | ||
Thread.sleep(2000); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you need this sleep? Can we replace with Awaiatility in order to make the test more resilient?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't need sleep, I did not check again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Motivation
now
MLTransactionLog
generatemanagedLedger
name is illegal.implement
generate correct name and can generate metrics.
Verifying this change
Add the tests for it
Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes
Dependencies (does it add or upgrade a dependency): (no)
The public API: (no)
The schema: (no)
The default values of configurations: (no)
The wire protocol: (no)
The rest endpoints: (no)
The admin cli options: (no)
Anything that affects deployment: (no)