-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reader support seek from separate messageId/time #10348
Conversation
/pulsarbot run-failure-checks |
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/Reader.java
Show resolved
Hide resolved
pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImpl.java
Outdated
Show resolved
Hide resolved
pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsReaderImpl.java
Outdated
Show resolved
Hide resolved
@315157973 thanks for your great work. Could you please help add docs accordingly? Then I can help review, thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
@merlimat @codelipenghui Can you review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding docs. I’ve left some comments, please check and keep consistencies for all occurrences, thanks.
Besides, docs are added to Reader.java
and Consumer.java
, Producer.java
needs to be updated?
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/Consumer.java
Outdated
Show resolved
Hide resolved
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/Consumer.java
Outdated
Show resolved
Hide resolved
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/Consumer.java
Outdated
Show resolved
Hide resolved
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/Consumer.java
Outdated
Show resolved
Hide resolved
…onsumer.java Co-authored-by: Yu Liu <50226895+Anonymitaet@users.noreply.github.com>
…onsumer.java Co-authored-by: Yu Liu <50226895+Anonymitaet@users.noreply.github.com>
…onsumer.java Co-authored-by: Yu Liu <50226895+Anonymitaet@users.noreply.github.com>
…onsumer.java Co-authored-by: Yu Liu <50226895+Anonymitaet@users.noreply.github.com>
Fixes #9301
Motivation
Currently in ReaderConfigurationData the API allow to ‘setStartMessageId’ only from single message ID and this apply to all consumers in the
MultiTopicsReaderImpl
.Is it possible to add start message per partition / topic.
Modifications
Reader can seek by function
Verifying this change
1 For partitioned topic, we can seek by time/messageId for every partition
2 For non-partitioned topic, we can seek by function