Resource locks should automatically revalidate after a metadata session is re-established #10351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
added
the
type/enhancement
merlimat
force-pushed
the
reacquiring-locks
branch
from
588fc9c
to
a442f05
Compare
…on is re-established
merlimat
force-pushed
the
reacquiring-locks
branch
from
a442f05
to
6266507
Compare
eolivelli
reviewed
Apr 24, 2021
|
"CI - Unit - Brokers - Other / unit-tests" build job hangs because of separate issue #10356 . |
|
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This change is to enhance the
ResourceLockto automatically revalidate the lock with the metadata store once a session is lost and then re-established.There are multiple state in which a lock can be left after the session is recovered, with either stale value that is going to get cleaned up or some other instance took over the lock.
This single implementation will be then used in all the places where we're taking ownerships in the code-base.