[Broker] Support array type claims in JWT #10375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/pulsarbot run-failure-checks |
merlimat
added
the
type/enhancement
merlimat
approved these changes
Apr 26, 2021
codelipenghui
pushed a commit
that referenced
this pull request
Jul 23, 2021
### Motivation In #10375, we add multi roles support for JWT authentication. But the authorization does not support multi roles currently. Only the first one in the roles array will be used during authorization. This PR adds multi roles support for authorization. ### Modifications * Add MultiRolesTokenAuthorizationProvider. It will check the permissions of all the roles in the roles array, and when one of the roles has permissions, it means that the current operation has permissions.
codelipenghui
pushed a commit
that referenced
this pull request
Jul 23, 2021
### Motivation In #10375, we add multi roles support for JWT authentication. But the authorization does not support multi roles currently. Only the first one in the roles array will be used during authorization. This PR adds multi roles support for authorization. ### Modifications * Add MultiRolesTokenAuthorizationProvider. It will check the permissions of all the roles in the roles array, and when one of the roles has permissions, it means that the current operation has permissions. (cherry picked from commit 62b5dfb)
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
### Motivation In apache#10375, we add multi roles support for JWT authentication. But the authorization does not support multi roles currently. Only the first one in the roles array will be used during authorization. This PR adds multi roles support for authorization. ### Modifications * Add MultiRolesTokenAuthorizationProvider. It will check the permissions of all the roles in the roles array, and when one of the roles has permissions, it means that the current operation has permissions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In some use cases of JWT, the type of role claim in the token is the array type.
For example, the token in Azure ActiveDirectory is like the following:
{ ...... "roles": [ "user1" ], ...... }Currently, pulsar's JWT cannot support handling array-type claims, we need to add support for this.
Modifications