[Issue 10170] Optimize locks in AuthenticationAthenz #10381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
massakam
added
the
type/cleanup
nkurihar
approved these changes
Apr 26, 2021
merlimat
reviewed
Apr 26, 2021
...lient-auth-athenz/src/main/java/org/apache/pulsar/client/impl/auth/AuthenticationAthenz.java
Outdated
Show resolved
Hide resolved
|
PTAL |
merlimat
approved these changes
Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10170
Currently,
AuthenticationAthenzusessynchronizedmore than necessary. I think the only variables that can cause race conditions with multiple threads areroleTokenandcachedRoleTokenTimestamp. Therefore, I introduced a locking object to prevent the race conditions of these two variables, and removed the othersynchronized.