[Functions] Completed work for PR #7555 to allow customizable function logging #10389
Conversation
|
Please verify these changes @jerrypeng @cdbartholomew @vaihtovirta @eolivelli |
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
|
@eolivelli I made some additional changes to make this feature more robust. Please review the new changes. |
|
/pulsarbot run-failure-checks |
devinbost
changed the title
|
@devinbost will this patch apply to branch-2.7? Or does it need some dependencies? |
|
@eolivelli Yes, this applies to branch-2.7 and doesn't have any other dependencies. |
…n logging (#10389) * Completed work for PR #7555 to allow customizable function logging * Fixed license header * PR #10389 Added null check to prevent test failures. * PR #10389 Added debug logging statement * PR #10389 Made changes more robust, added default value, and fixed NullPointerException * PR #10389 Improved backwards compatibility Co-authored-by: Devin Bost <dbost@overstock.com> (cherry picked from commit d757db1)
|
cherry picked to branch-2.7 |
eolivelli
added
cherry-picked/branch-2.7
Anonymitaet
added
the
doc-required
|
Hi @devinbost thanks for your great work. I'm adding docs for this PR but have some questions documented here, could you please take a look? Many thanks! |
|
@Anonymitaet Thanks for your help with the docs. I'll get this taken care of today. |
|
@Anonymitaet Please see #10617 |
|
@devinbost many thanks for your contribution. I've reviewed your doc PR, PTAL. |
Anonymitaet
removed
the
doc-required
…ion (apache#10617) This PR documents the feature added by apache#10389 and provides some additional information about how to use Log4j in Pulsar to configure Pulsar Function log levels.
…ion (apache#10617) This PR documents the feature added by apache#10389 and provides some additional information about how to use Log4j in Pulsar to configure Pulsar Function log levels.
This PR completes the work started by @g0715158 in PR #7555 to allow customization of the Pulsar function log level.
I created a new PR because it looked like the branch for that repo (
g0715158:master) involved a change for a different issue, and Github indicated the repo had been deleted. (I was unable to find the original commits on that repo in a branch.)@g0715158 Please let me know if you'd like to create a branch with your changes so you can get credit for your work. (In that case, I'll delete this PR and add my commits to your branch.)
Fixes #10205