[Transaction] Fix transaction buffer client channel not active problem. #10407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 28, 2021 11:54
eolivelli
requested changes
Apr 28, 2021
| cache.invalidate(topic); | ||
| cb.completeExceptionally(throwable); | ||
| pendingRequests.remove(requestId); |
There was a problem hiding this comment.
Why are you removing this line?
There was a problem hiding this comment.
if run here, the request don't put in pendingRequests. so remove this line
eolivelli
approved these changes
Apr 28, 2021
| cache.invalidate(topic); | ||
| cb.completeExceptionally(throwable); | ||
| pendingRequests.remove(requestId); |
lhotari
reviewed
Apr 28, 2021
| clientCnx.registerTransactionBufferHandler(TransactionBufferHandlerImpl.this); | ||
| synchronized (TransactionBufferHandlerImpl.class) { |
There was a problem hiding this comment.
It seems odd to use the Class object as an object monitor. Is this intentional?
Did you mean to have synchronized (TransactionBufferHandlerImpl.this) { instead?
There was a problem hiding this comment.
it my mistake, good catch!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
when channel is not active, it will not invalidate the
ClientCnx.implement
check channel active.
Verifying this change
Add the tests for it
Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes
Dependencies (does it add or upgrade a dependency): (no)
The public API: (no)
The schema: (no)
The default values of configurations: (no)
The wire protocol: (no)
The rest endpoints: (no)
The admin cli options: (no)
Anything that affects deployment: (no)