Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pulsar-broker] Handle NPE in unblock stuck subscrption task when dis… #10430

Merged
merged 1 commit into from May 4, 2021
Merged

[pulsar-broker] Handle NPE in unblock stuck subscrption task when dis… #10430

merged 1 commit into from May 4, 2021

Conversation

rdhabalia
Copy link
Contributor

…patcher is not created

Motivation

It fixes #10429 NPE when subscription has not created dispatcher yet.

2021-04-29T00:11:51,161 [pulsar-stats-updater-29-1] ERROR org.apache.pulsar.broker.service.persistent.PersistentTopic - Got exception when creating consumer stats for subscription __compaction: null
java.lang.NullPointerException: null
at org.apache.pulsar.broker.service.persistent.PersistentSubscription.checkAndUnblockIfStuck(PersistentSubscription.java:1101) ~[org.apache.pulsar-pulsar-broker-2.8.0-SNAPSHOT.jar:2.8.0-SNAPSHOT]
at org.apache.pulsar.broker.service.persistent.PersistentTopic.lambda$updateRates$45(PersistentTopic.java:1642) ~[org.apache.pulsar-pulsar-broker-2.8.0-SNAPSHOT.jar:2.8.0-SNAPSHOT]

@rdhabalia rdhabalia added this to the 2.8.0 milestone Apr 29, 2021
@rdhabalia rdhabalia self-assigned this Apr 29, 2021
@lhotari
Copy link
Member

lhotari commented Apr 29, 2021

/pulsarbot run-failure-checks

@eolivelli eolivelli merged commit 9982492 into apache:master May 4, 2021
@devinbost
Copy link
Contributor

@rdhabalia nice work

@lhotari lhotari mentioned this pull request May 10, 2021
Closed
eolivelli pushed a commit to eolivelli/pulsar that referenced this pull request May 11, 2021
@rdhabalia @eolivelli
[pulsar-broker] Handle NPE in unblock stuck subscrption task when dis…
410aed7 
…patcher is not created (apache#10430)
lhotari pushed a commit to datastax/pulsar that referenced this pull request Jun 21, 2021
@rdhabalia @lhotari
[pulsar-broker] Handle NPE in unblock stuck subscrption task when dis…
a40bcce 
…patcher is not created (apache#10430)

(cherry picked from commit 9982492)
@codelipenghui
Copy link
Contributor

branch-2.7 does not have the feature of allowing the broker to discover and unblock stuck subscription so we don't need to cherry-pick this one to branch-2.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhotari lhotari lhotari approved these changes

@sijie sijie sijie approved these changes

@jerrypeng jerrypeng jerrypeng approved these changes

@eolivelli eolivelli eolivelli approved these changes

@codelipenghui codelipenghui codelipenghui approved these changes

@merlimat merlimat Awaiting requested review from merlimat

@gmcdonald gmcdonald Awaiting requested review from gmcdonald

@jiazhai jiazhai Awaiting requested review from jiazhai

@nkurihar nkurihar Awaiting requested review from nkurihar

Assignees

@rdhabalia rdhabalia

Labels
area/broker
Projects
None yet
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.

NPE when creating consumer stats for subscription __compaction from checkAndUnblockIfStuck()
7 participants
@rdhabalia @lhotari @devinbost @codelipenghui @sijie @jerrypeng @eolivelli