-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pulsar-io] Using ObjectMapper instead of Gson to parse Source/SInk configuration #10441
Conversation
fixed minor issue in closing some of the PulsarClientImpl resources
private void shutdownEventLoopGroup(EventLoopGroup eventLoopGroup) throws PulsarClientException { | ||
if (createdEventLoopGroup && !eventLoopGroup.isShutdown()) { | ||
if (createdEventLoopGroup && eventLoopGroup != null && !eventLoopGroup.isShutdown()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was throwing an exception when this method was called from constructor if the exception was thrown before assigning parameter passed eventLoopGroup to the member variable eventLoopGroup. The same is for the cnxPool.
@MarvinCai @eolivelli @315157973 @lhotari kindly review it |
/pulsarbot run-failure-checks |
...ctions/instance/src/main/java/org/apache/pulsar/functions/instance/JavaInstanceRunnable.java
Outdated
Show resolved
Hide resolved
pulsar-client/src/main/java/org/apache/pulsar/client/impl/PulsarClientImpl.java
Outdated
Show resolved
Hide resolved
/pulsarbot run-failure-checks |
Fixes #10440
Motivation
Data types should be preserved after deserializing the sink/source config.
Modifications
Using ObjectMapper instead of Gson to parse the config.
This change added tests and can be verified as follows:
(example:)
Added unit tests
The schema: don't know