[pulsar-io] Using ObjectMapper instead of Gson to parse Source/SInk configuration #10441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed minor issue in closing some of the PulsarClientImpl resources
| private void shutdownEventLoopGroup(EventLoopGroup eventLoopGroup) throws PulsarClientException { | ||
| if (createdEventLoopGroup && !eventLoopGroup.isShutdown()) { | ||
| if (createdEventLoopGroup && eventLoopGroup != null && !eventLoopGroup.isShutdown()) { |
There was a problem hiding this comment.
this was throwing an exception when this method was called from constructor if the exception was thrown before assigning parameter passed eventLoopGroup to the member variable eventLoopGroup. The same is for the cnxPool.
abhilashmandaliya
changed the title
|
@MarvinCai @eolivelli @315157973 @lhotari kindly review it |
|
/pulsarbot run-failure-checks |
merlimat
reviewed
Apr 29, 2021
...ctions/instance/src/main/java/org/apache/pulsar/functions/instance/JavaInstanceRunnable.java
Outdated
Show resolved
Hide resolved
pulsar-client/src/main/java/org/apache/pulsar/client/impl/PulsarClientImpl.java
Outdated
Show resolved
Hide resolved
merlimat
added
the
type/enhancement
|
/pulsarbot run-failure-checks |
merlimat
approved these changes
May 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10440
Motivation
Data types should be preserved after deserializing the sink/source config.
Modifications
Using ObjectMapper instead of Gson to parse the config.
This change added tests and can be verified as follows:
(example:)
Added unit tests
The schema: don't know