Fix publish callback's entry data is null during ledger rollover #10467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/pulsarbot run-failure-checks |
merlimat
approved these changes
May 3, 2021
eolivelli
pushed a commit
to eolivelli/pulsar
that referenced
this pull request
May 11, 2021
…che#10467) * Fix publish callback's entry data is null during ledger rollover * Don't call recycle() when the callback is null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#9257 added an extra
ByteBufparameter to managed ledger'sAddEntryCallback#addCompleteso that broker can get a buffer view of the entry when it's persisted successfully. However, when a ledger is full and the rollover is triggered, theaddCompletemethod will be triggered inOpAddEntry#closeCompleteand the argument is null.Modifications
datawhenledger.asyncCloseis called inOpAddEntry#safeRun, and pass thedatatocb.addComplete, after that, release thedata.Verifying this change
This change is already covered by existing tests, such as ManagedLedgerTest#asyncAddEntryWithoutError.