[Java client] Fix behaviour of Schema.AUTO_CONSUME() with KeyValueSchema and multi versions #10492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ema and multi versions
eolivelli
force-pushed
the
fix/keyvalue-schema-evolution
branch
from
e38aced
to
c9e892c
Compare
eolivelli
changed the title
codelipenghui
approved these changes
May 7, 2021
|
@codelipenghui this change is relevant only when you consume a KeyValue topic with AUTO_CONSUME() and you use the new GenericObject/getNativeObject() API. this is not possible in 2.7.x, I am removing the 2.7.3 label |
congbobo184
approved these changes
May 7, 2021
merlimat
approved these changes
May 7, 2021
eolivelli
added a commit
to eolivelli/pulsar
that referenced
this pull request
May 11, 2021
…ema and multi versions (apache#10492) Co-authored-by: Enrico Olivelli <eolivelli@apache.org>
eolivelli
added a commit
to datastax/pulsar
that referenced
this pull request
May 12, 2021
…ema and multi versions (apache#10492) Co-authored-by: Enrico Olivelli <eolivelli@apache.org> (cherry picked from commit 9b92dc2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Schema.AUTO_CONSUME() does not work with KeyValueSchema and multi version schemas.
This is because the generated AVRO Schema Reader is configured with useProvidedSchemaAsReaderSchema=true.
Add new test cases for this use case:
We have two variants of the test: