[fix #10235] fix deadlock on Monitoring thread blocked by LeaderService.isLeader()
#10502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codelipenghui
requested review from
jerrypeng,
sijie and
merlimat
and removed request for
jerrypeng
sijie
approved these changes
May 8, 2021
1 task
codelipenghui
pushed a commit
that referenced
this pull request
May 9, 2021
…ce.isLeader() (#10512) --- Fixes #10235 According to #10235, when `LeaderService` is changing leadership status (like losing leadership, or becoming a leader), the `LeaderService` will be locked with `synchronized` block. Which will block other threads if calling `LeaderService.isLeader()`. This PR changes `ClusterServiceCoordinator` and `WorkerStatsManager` to check if is leader from `MembershipManager`, which will not block other threads if `LeaderService` is at `synchronized` block. Also, this PR will not resolve the root cause of #10235, since there is lack of context about blocked reader for the `FunctionAssignmentTailer`. - [ ] Make sure that the change passes the CI checks. --- Original PR is #10502
eolivelli
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 11, 2021
…ce.isLeader() (apache#10512) --- Fixes apache#10235 According to apache#10235, when `LeaderService` is changing leadership status (like losing leadership, or becoming a leader), the `LeaderService` will be locked with `synchronized` block. Which will block other threads if calling `LeaderService.isLeader()`. This PR changes `ClusterServiceCoordinator` and `WorkerStatsManager` to check if is leader from `MembershipManager`, which will not block other threads if `LeaderService` is at `synchronized` block. Also, this PR will not resolve the root cause of apache#10235, since there is lack of context about blocked reader for the `FunctionAssignmentTailer`. - [ ] Make sure that the change passes the CI checks. --- Original PR is apache#10502
eolivelli
pushed a commit
to eolivelli/pulsar
that referenced
this pull request
May 11, 2021
…rService.isLeader() (apache#10502) Fixes apache#10235 ### Motivation According to apache#10235, when `LeaderService` is changing leadership status (like losing leadership, or becoming a leader), the `LeaderService` will be locked with `synchronized` block. Which will block other threads if calling `LeaderService.isLeader()`. This PR changes `ClusterServiceCoordinator` and `WorkerStatsManager` to check if is leader from `MembershipManager`, which will not block other threads if `LeaderService` is at `synchronized` block. Also, this PR will not resolve the root cause of apache#10235, since there is lack of context about blocked reader for the `FunctionAssignmentTailer`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10235
Motivation
According to #10235, when
LeaderServiceis changing leadership status (like losing leadership, or becoming a leader), theLeaderServicewill be locked withsynchronizedblock. Which will block other threads if callingLeaderService.isLeader(). This PR changesClusterServiceCoordinatorandWorkerStatsManagerto check if is leader fromMembershipManager, which will not block other threads ifLeaderServiceis atsynchronizedblock.Also, this PR will not resolve the root cause of #10235, since there is lack of context about blocked reader for the
FunctionAssignmentTailer.Verifying this change