Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#10503] allow user to set custom configs to plugin worker service #10504

Conversation

freeznet
Copy link
Contributor

@freeznet freeznet commented May 7, 2021

Fixes #10503

Motivation

#8560 provide an interface for functions worker service and allows user to implement their own functions worker as a plugin functions worker. It would be great if the user can pass some custom settings to plugin functions worker service through WorkerConfig.

Modifications

  • add functionsWorkerServiceCustomConfigs to WorkerConfig

Verifying this change

  • Make sure that the change passes the CI checks.

@freeznet
Copy link
Contributor Author

freeznet commented May 7, 2021

@sijie @merlimat @codelipenghui @nlu90 @tuteng @fantapsody please help to review this PR if you have time, thanks.

@eolivelli eolivelli merged commit 9bdc9d2 into apache:master May 8, 2021
eolivelli pushed a commit to eolivelli/pulsar that referenced this pull request May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[functions worker] allow custom configs to plugin worker service
4 participants