PIP-45: Migrate NamespaceService to use MetadataStore #10532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
added
the
type/enhancement
eolivelli
approved these changes
May 11, 2021
| } | ||
| }, null); | ||
| return isExistFuture; | ||
| return pulsar.getLocalMetadataStore().exists(ServiceUnitUtils.path(bundle)); |
There was a problem hiding this comment.
it is amazing to see how much this code is simpler !
pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/NamespaceService.java
Outdated
Show resolved
Hide resolved
sijie
approved these changes
May 15, 2021
rdhabalia
approved these changes
May 18, 2021
…ndle from MetadataStore thread
…ve mix sync & async operations
yangl
pushed a commit
to yangl/pulsar
that referenced
this pull request
Jun 23, 2021
* PIP-45: Migrate NamespaceService to use MetadataStore * Fixed copying policies to local store * Fixed checkstyle * Fixed tests * Fixed test * Fixed handling of BadVersionException * Converted bundle split into an HTTP async operation * Fixed issues in concurrent bundle splits * Fixed checkstyle * Make sure the ownership is triggered for the first attempt * validateTopicOwnershipAsync * Fixed deadlock when removeTopicFromCache calls NamespaceService.getBundle from MetadataStore thread * Fixed checkstyle * Fixed handling of future composition in validateTopicOwnershipAsync * In internalCreateSubscriptionForNonPartitionedTopic() we shouldn't have mix sync & async operations * Fixed checkstyle * Fixed internalUnloadNonPartitionedTopic * Fixed mixed sync-async usage of NamespaceService.getBundle * Use awaitility in AdminTest * validateGlobalNamespaceOwnership should also be done asynchronously * Fixed checkstyle * Fixed missing , * Try to get stack traces for timedout test * Added async version of getTopicReference * Removed import * Fixed test mocks * Reflect that removeTopicFromCache is an async operation
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
* PIP-45: Migrate NamespaceService to use MetadataStore * Fixed copying policies to local store * Fixed checkstyle * Fixed tests * Fixed test * Fixed handling of BadVersionException * Converted bundle split into an HTTP async operation * Fixed issues in concurrent bundle splits * Fixed checkstyle * Make sure the ownership is triggered for the first attempt * validateTopicOwnershipAsync * Fixed deadlock when removeTopicFromCache calls NamespaceService.getBundle from MetadataStore thread * Fixed checkstyle * Fixed handling of future composition in validateTopicOwnershipAsync * In internalCreateSubscriptionForNonPartitionedTopic() we shouldn't have mix sync & async operations * Fixed checkstyle * Fixed internalUnloadNonPartitionedTopic * Fixed mixed sync-async usage of NamespaceService.getBundle * Use awaitility in AdminTest * validateGlobalNamespaceOwnership should also be done asynchronously * Fixed checkstyle * Fixed missing , * Try to get stack traces for timedout test * Added async version of getTopicReference * Removed import * Fixed test mocks * Reflect that removeTopicFromCache is an async operation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Converted the NamespaceService to use MetadataStore instead of direct ZK access.