Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ack receipt version support logic #10551

Merged
merged 1 commit into from
May 12, 2021
Merged

Conversation

yangl
Copy link
Contributor

@yangl yangl commented May 12, 2021

Motivation

if (conf.isAckReceiptEnabled() &&
                    Commands.peerSupportsAckReceipt(clientCnx.getRemoteEndpointProtocolVersion())) {
                log.warn("Server don't support ack for receipt! " +
                        "ProtoVersion >=17 support! nowVersion : {}", clientCnx.getRemoteEndpointProtocolVersion());
            }

the ack receipt version support logic Commands.peerSupportsAckReceipt(clientCnx.getRemoteEndpointProtocolVersion()) should add not.

Modifications

add not !Commands.peerSupportsAckReceipt(clientCnx.getRemoteEndpointProtocolVersion()

Signed-off-by: YANGLiiN <ielin@qq.com>
@eolivelli eolivelli requested review from congbobo184 and codelipenghui and removed request for congbobo184 May 12, 2021 08:11
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@eolivelli eolivelli merged commit 4f8dd32 into apache:master May 12, 2021
@codelipenghui codelipenghui added this to the 2.8.0 milestone May 12, 2021
@yangl yangl deleted the minor_bugfix branch May 12, 2021 13:41
@codelipenghui
Copy link
Contributor

We don't have ack receipt in branch-2.7, so don't need to cherry-pick this fix to branch-2.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants