Fixed missed ZK caching when fetching list of namespaces for a tenant #10594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
added
type/bug
merlimat
requested review from
addisonj,
sijie,
rdhabalia,
jerrypeng and
codelipenghui
codelipenghui
approved these changes
May 15, 2021
sijie
approved these changes
May 15, 2021
eolivelli
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 18, 2021
…apache#10594) * Fixed missed ZK caching when fetching list of namespaces for a tenant * Fixed generic object type (cherry picked from commit 883e0d4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The ZK reads triggered by the "get namespaces of a tenant" admin operation are being issued directly on the ZK client and therefore are not getting cached by brokers.
This change is only for 2.7 branch. The issue is not present in current master since the code was already ported to use MetadataStore API.