-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup initial namespaces with MetadataStore #10612
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We may have a problem with the new test case as the new refactored method may call System.exit, breaking the execution of the JVM.
I would be better to be able to pass to the PulsarInitialNamespaceSetup.main() function a callback to be executed in case of failure and use that version for tests
PulsarInitialNamespaceSetup.main(arguments, (exitCode) -> {
fail the test
});
@eolivelli Thanks for the idea! I modified the code in a similar way by moving the code from |
@eolivelli @fantapsody has already addressed the comments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Motivation
Refactor the initial namespaces setup command to use the new
MetadataStore
API.Explain here the context, and why you're making that change. What is the problem you're trying to solve.
Modifications
PulsarInitialNamespaceSetup
command to use the newMetadataStore
API.Describe the modifications you've done.
Verifying this change
This change is already covered by existing tests, such as
ClusterMetadataSetupTest
.(or)
This change added tests and can be verified as follows:
PulsarInitialNamespaceSetup
commandDoes this pull request potentially affect one of the following parts:
If
yes
was chosen, please highlight the changesDocumentation