Fixed issues in pulsar-client shading configuration #10614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
requested review from
sijie,
rdhabalia,
jerrypeng,
codelipenghui and
congbobo184
sijie
approved these changes
May 18, 2021
codelipenghui
approved these changes
May 18, 2021
|
This is dependent on #10616 changes |
lhotari
approved these changes
May 18, 2021
yangl
pushed a commit
to yangl/pulsar
that referenced
this pull request
Jun 23, 2021
### Motivation There are few issues in the dependencies exposed by `pulsar-client` and `pulsar-client-all` modules: 1. Protobuf is exposed as a dependency, being pulled by `pulsar-transaction-common`, even though it's not used anymore. 2. `pulsar-client-api` must not be included in the shaded jar, instead it needs to stay as a transitive dependency of the shaded jar 3. Some depedendencies were not being included in the shaded jar
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
### Motivation There are few issues in the dependencies exposed by `pulsar-client` and `pulsar-client-all` modules: 1. Protobuf is exposed as a dependency, being pulled by `pulsar-transaction-common`, even though it's not used anymore. 2. `pulsar-client-api` must not be included in the shaded jar, instead it needs to stay as a transitive dependency of the shaded jar 3. Some depedendencies were not being included in the shaded jar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There are few issues in the dependencies exposed by
pulsar-clientandpulsar-client-allmodules:pulsar-transaction-common, even though it's not used anymore.pulsar-client-apimust not be included in the shaded jar, instead it needs to stay as a transitive dependency of the shaded jar