[Functions] Process async results in the same Java runnable thread #10618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*Motivation* After introducing the support for async functions, the java function processing semantic is not enforced. For example, if it fails to write a sink, it doesn't fail the java instance or fail the message. Hence it keeps receiving messages but never ack or nack. *Modification* Change the way how aysnc function requests are processed to fix the issues we have seen in Kinesis connector.
sijie
requested review from
merlimat,
addisonj,
jerrypeng,
jiazhai and
codelipenghui
nlu90
reviewed
May 17, 2021
| handleResult(currentRecord, result); | ||
| } else { | ||
| // process the asynchronous results | ||
| processAsyncResults(); |
There was a problem hiding this comment.
The null result indicates the current record is placed into the queue for async processing.
The processAsyncResults() method takes the first element from the queue and checks/proceeds with the result.
- It seems a newly added record triggers the check of whether the oldest added record is done. This behavior is undesirable since records are independent.
- I'm wondering there'll always be one element left in the queue regardless whether it's done or not.
There was a problem hiding this comment.
@nlu90 Nice catch! I have addressed your comment in commit 326ae15
nlu90
reviewed
May 18, 2021
| srcRecord, t); | ||
| stats.incrUserExceptions(t); | ||
| srcRecord.fail(); | ||
| private void processAsyncResults() throws InterruptedException { |
nlu90
approved these changes
May 18, 2021
merlimat
approved these changes
May 18, 2021
codelipenghui
approved these changes
May 18, 2021
codelipenghui
pushed a commit
that referenced
this pull request
May 21, 2021
…10618) * [Functions] Process async results in the same Java runnable thread *Motivation* After introducing the support for async functions, the java function processing semantic is not enforced. For example, if it fails to write a sink, it doesn't fail the java instance or fail the message. Hence it keeps receiving messages but never ack or nack. *Modification* Change the way how aysnc function requests are processed to fix the issues we have seen in Kinesis connector. * Process the async results in the different thread (cherry picked from commit 1cbd5b4)
yangl
pushed a commit
to yangl/pulsar
that referenced
this pull request
Jun 23, 2021
…pache#10618) * [Functions] Process async results in the same Java runnable thread *Motivation* After introducing the support for async functions, the java function processing semantic is not enforced. For example, if it fails to write a sink, it doesn't fail the java instance or fail the message. Hence it keeps receiving messages but never ack or nack. *Modification* Change the way how aysnc function requests are processed to fix the issues we have seen in Kinesis connector. * Process the async results in the different thread
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
…pache#10618) * [Functions] Process async results in the same Java runnable thread *Motivation* After introducing the support for async functions, the java function processing semantic is not enforced. For example, if it fails to write a sink, it doesn't fail the java instance or fail the message. Hence it keeps receiving messages but never ack or nack. *Modification* Change the way how aysnc function requests are processed to fix the issues we have seen in Kinesis connector. * Process the async results in the different thread
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
After introducing the support for async functions, the java function processing semantic is not enforced.
For example, if it fails to write a sink, it doesn't fail the java instance or fail the message. Hence it keeps
receiving messages but never ack or nack.
Modification
Change the way how aysnc function requests are processed to fix the issues we have seen in Kinesis connector.