Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converted bundle split into an HTTP async operation #10619

Merged
merged 3 commits into from
May 18, 2021

Conversation

merlimat
Copy link
Contributor

Motivation

The bundle split operation should not keep the Jetty thread blocked while the split is being done, to avoid having a deadlock when broker is trying to make other calls to HTTP service.

@merlimat merlimat added the type/bug The PR fixed a bug or issue reported a bug label May 17, 2021
@merlimat merlimat added this to the 2.8.0 milestone May 17, 2021
@merlimat merlimat self-assigned this May 17, 2021
@merlimat merlimat merged commit 8f3a564 into apache:master May 18, 2021
@merlimat merlimat deleted the bundle-split branch May 18, 2021 02:13
@lhotari
Copy link
Member

lhotari commented May 18, 2021

@merlimat Does this PR happen to fix issues such as #5510 ?

@frankjkelly
Copy link
Contributor

@lhotari @merlimat that would be nice if there's an improvement - currently under load as we create tens of thousands of new topics we have currently chosen to set loadBalancerAutoBundleSplitEnabled=false as a work-around in 2.6.1

yangl pushed a commit to yangl/pulsar that referenced this pull request Jun 23, 2021
* Converted bundle split into an HTTP async operation

* Fixed tests

* Fixed checkstyle
bharanic-dev pushed a commit to bharanic-dev/pulsar that referenced this pull request Mar 18, 2022
* Converted bundle split into an HTTP async operation

* Fixed tests

* Fixed checkstyle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants