Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

branch-2.7: Remove reference to ProducerSpec from Pulsar Functions GO #10635

Closed
wants to merge 1 commit into from

Conversation

eolivelli
Copy link
Contributor

@eolivelli eolivelli commented May 19, 2021

Motivation

Integration tests on branch-2.7 do not work, because of a bunch of lines of code that were cherry-picked to branch-2.7.

Steps to reproduce

git checkout branch-2.7
mvn clean install -DskipTests
mvn package -Pdocker -f docker/pom.xml
mvn clean install -DintegrationTests -f tests/docker-images/pom.xml

This is the error:

[INFO] [91m# github.com/apache/pulsar/pulsar-function-go/pf
[INFO] pf/instance.go:227:22: undefined: pulsar.DefaultBatchBuilder
[INFO] pf/instance.go:229:45: gi.context.instanceConf.funcDetails.Sink.ProducerSpec undefined (type *api.SinkSpec has no field or method ProducerSpec)
[INFO] pf/instance.go:230:59: gi.context.instanceConf.funcDetails.Sink.ProducerSpec undefined (type *api.SinkSpec has no field or method ProducerSpec)
[INFO] pf/instance.go:233:24: undefined: pulsar.KeyBasedBatchBuilder
[INFO] [0m

Modifications

Remove the lines that do not compile because of missing dependencies (ProducerSpec).

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

@eolivelli eolivelli self-assigned this May 19, 2021
@eolivelli eolivelli changed the title Remove ProducerSpec from Pulsar Functions GO, missing dependencies Remove ProducerSpec from Pulsar Functions GO, missing ProducerSpec May 19, 2021
@eolivelli eolivelli changed the title Remove ProducerSpec from Pulsar Functions GO, missing ProducerSpec Remove reference to ProducerSpec from Pulsar Functions GO May 19, 2021
@eolivelli eolivelli changed the title Remove reference to ProducerSpec from Pulsar Functions GO branch-2.7: Remove reference to ProducerSpec from Pulsar Functions GO May 19, 2021
@eolivelli
Copy link
Contributor Author

@codelipenghui @merlimat PTAL

@sijie sijie requested a review from wolfstudy May 28, 2021 15:41
@sijie
Copy link
Member

sijie commented May 28, 2021

@wolfstudy Can you review this?

@eolivelli eolivelli closed this Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants