[Transaction] Transaction admin api transaction in buffer stats #10642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
May 19, 2021 16:54
…_admin_api # Conflicts: # pulsar-client-tools-test/src/test/java/org/apache/pulsar/admin/cli/PulsarAdminToolTest.java
…nto congbobo184_transaction_admin_api_transaction_inbuffer_stats # Conflicts: # pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminApiTest.java
codelipenghui
added
area/transaction
component/txn/coordinator
doc-required
added 6 commits
May 20, 2021 11:03
…nto congbobo184_transaction_admin_api_transaction_inbuffer_stats
…ion_inbuffer_stats # Conflicts: # pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/TransactionsBase.java # pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v3/Transactions.java # pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/v3/AdminApiTransactionTest.java # pulsar-client-admin-api/src/main/java/org/apache/pulsar/client/admin/Transactions.java # pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/TransactionsImpl.java # pulsar-client-tools-test/src/test/java/org/apache/pulsar/admin/cli/PulsarAdminToolTest.java # pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdTransactions.java
Anonymitaet
added
doc
Comment on lines
47
to
51
| @Parameter(names = {"-c", "--coordinator-id"}, description = "the coordinator id", required = true) | ||
| private int coordinatorId; | ||
|
|
||
| @Parameter(names = {"-id", "--sequence-id"}, description = "the sequence id", required = true) | ||
| private int sequenceId; |
There was a problem hiding this comment.
sequenceId is confusing here because this is also a concept in the producer side, it's better to use --transactionId here? Such as --transactionId (0,123456)
| @ApiResponse(code = 404, message = "Tenant or cluster or namespace or topic doesn't exist"), | ||
| @ApiResponse(code = 503, message = "This Broker is not configured " | ||
| + "with transactionCoordinatorEnabled=true."), | ||
| @ApiResponse(code = 500, message = "Topic don't owner by this broker!"), |
codelipenghui
approved these changes
May 24, 2021
yangl
pushed a commit
to yangl/pulsar
that referenced
this pull request
Jun 23, 2021
…he#10642) ## Motivation Transaction add admin api `getTransactionInBufferStats` ## implement ``` @DaTa public class TransactionInBufferStats { /** The start position of this transaction in transaction buffer. */ public String startPosition; /** The flag of this transaction have been aborted. */ public boolean aborted; } ``` This is transaction buffer metrics.
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
…he#10642) ## Motivation Transaction add admin api `getTransactionInBufferStats` ## implement ``` @DaTa public class TransactionInBufferStats { /** The start position of this transaction in transaction buffer. */ public String startPosition; /** The flag of this transaction have been aborted. */ public boolean aborted; } ``` This is transaction buffer metrics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Transaction add admin api
getTransactionInBufferStatsimplement
This is transaction buffer metrics.
Verifying this change
Add the tests for it
Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes
Dependencies (does it add or upgrade a dependency): (no)
The public API: (no)
The schema: (no)
The default values of configurations: (no)
The wire protocol: (no)
The rest endpoints: (no)
The admin cli options: (yes)
Anything that affects deployment: (no)