[Issue-10611] consumer related topic stats only available while consumer or reader are connected #10644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mer or reader are connected
| subscriptions.remove(subscriptionName); | ||
| PersistentSubscription sub = subscriptions.remove(subscriptionName); | ||
| // preserve accumulative stats form removed subscription | ||
| SubscriptionStats stats = sub.getStats(false, false); |
There was a problem hiding this comment.
Do you think it'd be worth adding specific getters for the two counters we want here? I am specifically concerned about the overhead of building out the whole SubscriptionStats object many times. I'm not sure how expensive the getStats method really is, though.
There was a problem hiding this comment.
removeSubscription does not happen that frequently.
There was a problem hiding this comment.
Oh, right. I had been thinking of consumers, not subscriptions.
|
@codelipenghui PTAL |
codelipenghui
approved these changes
May 21, 2021
yangl
pushed a commit
to yangl/pulsar
that referenced
this pull request
Jun 23, 2021
…mer or reader are connected (apache#10644) Fixes apache#10611
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
…mer or reader are connected (apache#10644) Fixes apache#10611
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(If this PR fixes a github issue, please add
Fixes #<xyz>.)Fixes #10611
Motivation
Stats report wrong values when consumers unsubscribe.
Modifications
Preserved specific stats for the consumer on its removal.
Verifying this change
(Please pick either of the following options)
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation