Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PIP-45: Initialize ManagedLedgerFactory with MetadataStore #10647

Merged
merged 6 commits into from
May 22, 2021
Merged

PIP-45: Initialize ManagedLedgerFactory with MetadataStore #10647

merged 6 commits into from
May 22, 2021

Conversation

merlimat
Copy link
Contributor

Motivation

Pass the MetadataStore instance from PulsarService directly to ManagedLedgerFactory. There are not anymore interactions of ManagedLedger with Zookeeper.

@merlimat merlimat added the type/feature The PR added a new feature or issue requested a new feature label May 20, 2021
@merlimat merlimat added this to the 2.8.0 milestone May 20, 2021
@merlimat merlimat self-assigned this May 20, 2021
@Anonymitaet
Copy link
Member

Hi @merlimat thanks for your contribution. Do the changes of this PR affect docs?

@merlimat
Copy link
Contributor Author

No changes for the documentation.

eolivelli
eolivelli approved these changes May 20, 2021
View reviewed changes
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

Lgtm

@merlimat merlimat merged commit d94c3f0 into apache:master May 22, 2021
@merlimat merlimat deleted the managed-ledger-metadata-store branch May 22, 2021 21:35
BewareMyPower added a commit to BewareMyPower/kop that referenced this pull request May 25, 2021
@BewareMyPower
Upgrade pulsar to 2.8.0-SNAPSHOT (b6ca040)
e390ee0 
apache/pulsar#10647 modified PulsarMockBookKeeper and BookKeeperClientFactory interface, so this PR introduced
bookkeeper-common dependency and excludes the netty-common dependency to avoid conflict like

> java.lang.NoSuchMethodError: io.netty.util.internal.PlatformDependent.putByte(Ljava/lang/Object;JB)V

Another change is downgrade Jackson version from 2.12.1 to 2.11.1. Otherwise, the following error would be encountered:

> java.lang.NoClassDefFoundError: com/fasterxml/jackson/core/util/JacksonFeature
yangl pushed a commit to yangl/pulsar that referenced this pull request Jun 23, 2021
@merlimat @yangl
PIP-45: Initialize ManagedLedgerFactory with MetadataStore (apache#10647
a131f82 
)

* PIP-45: Initialize ManagedLedgerFactory with MetadataStore

* Fixed using the correct metadatastore in PulsarClusterMetadataTeardown

* Fixed test

* Removed multiple test invocations

* Fixed package manager tests implementation
@hangc0276 hangc0276 mentioned this pull request Feb 17, 2022
Closed
3 tasks
@wenbingshen wenbingshen mentioned this pull request Mar 1, 2022
Merged
1 task
bharanic-dev pushed a commit to bharanic-dev/pulsar that referenced this pull request Mar 18, 2022
@merlimat @ciaocloud
PIP-45: Initialize ManagedLedgerFactory with MetadataStore (apache#10647
4f95bd5 
)

* PIP-45: Initialize ManagedLedgerFactory with MetadataStore

* Fixed using the correct metadatastore in PulsarClusterMetadataTeardown

* Fixed test

* Removed multiple test invocations

* Fixed package manager tests implementation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eolivelli eolivelli eolivelli approved these changes

@codelipenghui codelipenghui codelipenghui approved these changes

@sijie sijie Awaiting requested review from sijie

@rdhabalia rdhabalia Awaiting requested review from rdhabalia

@jerrypeng jerrypeng Awaiting requested review from jerrypeng

Assignees

@merlimat merlimat

Labels
type/feature The PR added a new feature or issue requested a new feature
Projects
None yet
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@merlimat @Anonymitaet @eolivelli @codelipenghui