Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Performance] Use single instance of parser #10664

Merged
merged 1 commit into from
May 21, 2021
Merged

[Performance] Use single instance of parser #10664

merged 1 commit into from
May 21, 2021

Conversation

addisonj
Copy link
Contributor

Fixes #10652

This is a minor change that optimizes the AuthProviderToken class to use
the same instance of the parser instead of many instance.

This minor change is covered by existing tests, with a small improvement
to not use a deprecated method

Fixes #10652

This is a minor change that optimizes the AuthProviderToken class to use
the same instance of the parser instead of many instance.

This minor change is covered by existing tests, with a small improvement
to not use a deprecated method
@lhotari lhotari added this to the 2.8.0 milestone May 21, 2021
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhotari lhotari requested a review from eolivelli May 21, 2021 07:18
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Nice work

@eolivelli eolivelli merged commit a6bb983 into master May 21, 2021
@eolivelli eolivelli deleted the auth_perf_fix branch May 21, 2021 09:59
eolivelli pushed a commit to datastax/pulsar that referenced this pull request May 21, 2021
Fixes apache#10652

This is a minor change that optimizes the AuthProviderToken class to use
the same instance of the parser instead of many instance.

This minor change is covered by existing tests, with a small improvement
to not use a deprecated method

(cherry picked from commit a6bb983)
eolivelli pushed a commit to datastax/pulsar that referenced this pull request May 21, 2021
Fixes apache#10652

This is a minor change that optimizes the AuthProviderToken class to use
the same instance of the parser instead of many instance.

This minor change is covered by existing tests, with a small improvement
to not use a deprecated method

(cherry picked from commit a6bb983)
lhotari pushed a commit to lhotari/pulsar that referenced this pull request May 26, 2021
Fixes apache#10652

This is a minor change that optimizes the AuthProviderToken class to use
the same instance of the parser instead of many instance.

This minor change is covered by existing tests, with a small improvement
to not use a deprecated method
yangl pushed a commit to yangl/pulsar that referenced this pull request Jun 23, 2021
Fixes apache#10652

This is a minor change that optimizes the AuthProviderToken class to use
the same instance of the parser instead of many instance.

This minor change is covered by existing tests, with a small improvement
to not use a deprecated method
codelipenghui pushed a commit that referenced this pull request Jun 26, 2021
Fixes #10652

This is a minor change that optimizes the AuthProviderToken class to use
the same instance of the parser instead of many instance.

This minor change is covered by existing tests, with a small improvement
to not use a deprecated method

(cherry picked from commit a6bb983)
@codelipenghui codelipenghui added the cherry-picked/branch-2.7 Archived: 2.7 is end of life label Jun 26, 2021
bharanic-dev pushed a commit to bharanic-dev/pulsar that referenced this pull request Mar 18, 2022
Fixes apache#10652

This is a minor change that optimizes the AuthProviderToken class to use
the same instance of the parser instead of many instance.

This minor change is covered by existing tests, with a small improvement
to not use a deprecated method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Performance] AuthenticationProviderToken.authenticateToken (JWT token parsing) creates a lot of allocations
4 participants