-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Performance] Use single instance of parser #10664
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #10652 This is a minor change that optimizes the AuthProviderToken class to use the same instance of the parser instead of many instance. This minor change is covered by existing tests, with a small improvement to not use a deprecated method
lhotari
approved these changes
May 21, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
eolivelli
approved these changes
May 21, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Nice work
eolivelli
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 21, 2021
Fixes apache#10652 This is a minor change that optimizes the AuthProviderToken class to use the same instance of the parser instead of many instance. This minor change is covered by existing tests, with a small improvement to not use a deprecated method (cherry picked from commit a6bb983)
eolivelli
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 21, 2021
Fixes apache#10652 This is a minor change that optimizes the AuthProviderToken class to use the same instance of the parser instead of many instance. This minor change is covered by existing tests, with a small improvement to not use a deprecated method (cherry picked from commit a6bb983)
lhotari
pushed a commit
to lhotari/pulsar
that referenced
this pull request
May 26, 2021
Fixes apache#10652 This is a minor change that optimizes the AuthProviderToken class to use the same instance of the parser instead of many instance. This minor change is covered by existing tests, with a small improvement to not use a deprecated method
yangl
pushed a commit
to yangl/pulsar
that referenced
this pull request
Jun 23, 2021
Fixes apache#10652 This is a minor change that optimizes the AuthProviderToken class to use the same instance of the parser instead of many instance. This minor change is covered by existing tests, with a small improvement to not use a deprecated method
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
Fixes apache#10652 This is a minor change that optimizes the AuthProviderToken class to use the same instance of the parser instead of many instance. This minor change is covered by existing tests, with a small improvement to not use a deprecated method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10652
This is a minor change that optimizes the AuthProviderToken class to use
the same instance of the parser instead of many instance.
This minor change is covered by existing tests, with a small improvement
to not use a deprecated method