[broker] Setup transaction metadata with metadata store #10677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codelipenghui
approved these changes
May 22, 2021
merlimat
approved these changes
May 22, 2021
yangl
pushed a commit
to yangl/pulsar
that referenced
this pull request
Jun 23, 2021
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Refactor the
initialize-transaction-coordinator-metadatacommand to use the newMetadataStoreAPI.Modifications
PulsarTransactionCoordinatorMetadataSetupclass to use the newMetadataStoreAPIcreateZkNode/createTenantIfAbsent/createNamespaceIfAbsentthat acceptZooKeeperas parametersVerifying this change
This change is already covered by existing tests, such as
TransactionMetaStoreAssignmentTest,TransactionBufferClientTest,TransactionCoordinatorClientTest