[Transaction] Fix transaction ack one topic with multi sub. #10689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codelipenghui
requested changes
May 24, 2021
| @@ -117,7 +117,7 @@ public synchronized void registerSendOp(CompletableFuture<MessageId> sendFuture) | |||
| return checkIfOpen().thenCompose(value -> { | |||
| synchronized (TransactionImpl.this) { | |||
| // we need to issue the request to TC to register the acked topic | |||
| return registerSubscriptionMap.compute(topic, (key, future) -> { | |||
| return registerSubscriptionMap.compute(topic + "-" + subscription, (key, future) -> { | |||
There was a problem hiding this comment.
This will bring risks when using - to connect the topic name and subscription name. For example, if we have a topic a-b and subscription name c, the key will be a-b-c, for topic a and subscription b-c, we also get the key a-b-c.
You can use Pair.of(topic, sub) as the key, or use a special connector which is not allowed in Pulsar topic name and sub name.
codelipenghui
added
area/transaction
component/txn/coordinator
area/client
and removed
component/txn/coordinator
labels
eolivelli
requested changes
May 24, 2021
|
@eolivelli @codelipenghui please review again thanks |
|
@codelipenghui PTAL |
codelipenghui
approved these changes
May 25, 2021
yangl
pushed a commit
to yangl/pulsar
that referenced
this pull request
Jun 23, 2021
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Now Transaction ack one topic with multi sub will be filtered. fix it.
implement
add topic + subName filter.
This is transaction component status.
Verifying this change
Add the tests for it
Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes
Dependencies (does it add or upgrade a dependency): (no)
The public API: (no)
The schema: (no)
The default values of configurations: (no)
The wire protocol: (no)
The rest endpoints: (no)
The admin cli options: (yes)
Anything that affects deployment: (no)