[Transaction] Transaction admin api get transaction metadata #10690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 17 commits
May 19, 2021 16:54
…_admin_api # Conflicts: # pulsar-client-tools-test/src/test/java/org/apache/pulsar/admin/cli/PulsarAdminToolTest.java
…nto congbobo184_transaction_admin_api_transaction_in_pendingack_stats
…nto congbobo184_transaction_admin_api_transaction_in_pendingack_stats
…ion_in_pendingack_stats
…ion_in_pendingack_stats # Conflicts: # pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/TransactionsBase.java # pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v3/Transactions.java # pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java # pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/v3/AdminApiTransactionTest.java # pulsar-client-admin-api/src/main/java/org/apache/pulsar/client/admin/Transactions.java # pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/TransactionsImpl.java # pulsar-client-tools-test/src/test/java/org/apache/pulsar/admin/cli/PulsarAdminToolTest.java # pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdTransactions.java
…ongbobo184_transaction_admin_api_get_transaction_status
…saction_status # Conflicts: # pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v3/Transactions.java # pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/v3/AdminApiTransactionTest.java # pulsar-client-admin-api/src/main/java/org/apache/pulsar/client/admin/Transactions.java # pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/TransactionsImpl.java # pulsar-client-tools-test/src/test/java/org/apache/pulsar/admin/cli/PulsarAdminToolTest.java # pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdTransactions.java
codelipenghui
requested changes
May 24, 2021
| Transactions transactions = pulsar().getAdminClient().transactions(); | ||
| TxnMeta txnMeta = pulsar().getTransactionMetadataStoreService() | ||
| .getTxnMeta(new TxnID(coordinatorId, sequenceID)).get(); | ||
| TxnID txnID = txnMeta.id(); |
There was a problem hiding this comment.
Will introduce NPE here.
| public CmdTransactions(Supplier<PulsarAdmin> admin) { | ||
| super("transactions", admin); | ||
| jcommander.addCommand("coordinator-status", new GetCoordinatorStatus()); | ||
| jcommander.addCommand("transaction-in-buffer-stats", new GetTransactionInBufferStats()); | ||
| jcommander.addCommand("transaction-in-pending-ack-stats", new GetTransactionInPendingAckStats()); | ||
| jcommander.addCommand("transaction-status", new GetTransactionStatus()); |
There was a problem hiding this comment.
It's better to use transaction-metadata here since we are using a transaction ID to fetch all transaction metadata through this command.
| @@ -117,7 +117,7 @@ public synchronized void registerSendOp(CompletableFuture<MessageId> sendFuture) | |||
| return checkIfOpen().thenCompose(value -> { | |||
| synchronized (TransactionImpl.this) { | |||
| // we need to issue the request to TC to register the acked topic | |||
| return registerSubscriptionMap.compute(topic, (key, future) -> { | |||
| return registerSubscriptionMap.compute(topic + "-" + subscription, (key, future) -> { | |||
There was a problem hiding this comment.
Seems not related to this PR?
added 2 commits
May 24, 2021 23:47
…ongbobo184_transaction_admin_api_get_transaction_status
congbobo184
added
the
doc
added 2 commits
May 25, 2021 09:23
…ongbobo184_transaction_admin_api_get_transaction_status
Anonymitaet
reviewed
May 25, 2021
pulsar-client-admin-api/src/main/java/org/apache/pulsar/client/admin/Transactions.java
Outdated
Show resolved
Hide resolved
…/admin/Transactions.java Co-authored-by: Yu Liu <50226895+Anonymitaet@users.noreply.github.com>
congbobo184
changed the title
codelipenghui
approved these changes
May 25, 2021
yangl
pushed a commit
to yangl/pulsar
that referenced
this pull request
Jun 23, 2021
…10690) ## Motivation Transaction add admin api `getTransactionMetadata` ## implement ``` @DaTa public class TransactionMetadata { /** The txnId of this transaction. */ public String txnId; /** The status of this transaction. */ public String status; /** The open time of this transaction. */ public long openTimestamp; /** The timeout of this transaction. */ public long timeoutAt; /** The producedPartitions of this transaction. */ public Map<String, TransactionInBufferStats> producedPartitions; /** The ackedPartitions of this transaction. */ public Map<String, Map<String, TransactionInPendingAckStats>> ackedPartitions; } ```
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
…10690) ## Motivation Transaction add admin api `getTransactionMetadata` ## implement ``` @DaTa public class TransactionMetadata { /** The txnId of this transaction. */ public String txnId; /** The status of this transaction. */ public String status; /** The open time of this transaction. */ public long openTimestamp; /** The timeout of this transaction. */ public long timeoutAt; /** The producedPartitions of this transaction. */ public Map<String, TransactionInBufferStats> producedPartitions; /** The ackedPartitions of this transaction. */ public Map<String, Map<String, TransactionInPendingAckStats>> ackedPartitions; } ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Transaction add admin api
getTransactionMetadataimplement
Verifying this change
Add the tests for it
Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes
Dependencies (does it add or upgrade a dependency): (no)
The public API: (no)
The schema: (no)
The default values of configurations: (no)
The wire protocol: (no)
The rest endpoints: (no)
The admin cli options: (yes)
Anything that affects deployment: (no)