[Doc] Add descriptions for managed cursor acknowledgment state #10695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anonymitaet
added
the
doc
Anonymitaet
requested review from
codelipenghui,
Jennifer88huang-zz and
Huanli-Meng
|
@codelipenghui @Sunny-Island @Huanli-Meng @jennifer88huang could you please help review? Thanks |
codelipenghui
approved these changes
May 25, 2021
Jennifer88huang-zz
approved these changes
May 25, 2021
| brk_ml_cursor_persistZookeeperSucceed(namespace="", ledger_name="", cursor_name:"")|Gauge|The number of acknowledgment states that is persistent to ZooKeeper. | ||
| brk_ml_cursor_persistZookeeperErrors(namespace="", ledger_name="", cursor_name:"")|Gauge|The number of ledger errors occurred when acknowledgment states fail to be persistent to ZooKeeper. | ||
| brk_ml_cursor_nonContiguousDeletedMessagesRange(namespace="", ledger_name="", cursor_name:"")|Gauge|The number of non-contiguous deleted messages ranges. | ||
|
|
||
| ### LoadBalancing metrics |
There was a problem hiding this comment.
Load balancing metrics
hangc0276
requested changes
May 25, 2021
| @@ -260,6 +260,26 @@ All the managedLedger metrics are labelled with the following labels: | |||
| | pulsar_ml_ReadEntriesSucceeded | Gauge | The number of readEntries requests that succeeded | | |||
| | pulsar_ml_StoredMessagesSize | Gauge | The total size of the messages in active ledgers (accounting for the multiple copies stored) | | |||
|
|
|||
| ### Managed cursor acknowledgment state | |||
|
|
|||
| The acknowledgment state is persistent to the ledger first. When the acknowledgment state fails to be persistent to the ledger, they are persistent to ZooKeeper. To track the stats of acknowledgment, you can configure the metrics for the managed cursor. | |||
There was a problem hiding this comment.
When persisting to the ledger fails, they will be persisted to ZooKeeper
may be better
There was a problem hiding this comment.
@hangc0276 thanks for your suggestion, but When persisting to the ledger fails, they will be persisted to ZooKeeper is grammatically inaccurate because it lacks a subject.
The original sentence is grammatically correct and it clearly indicates the subject (acknowledgment state).
So could you help approve this PR? Then this PR can be merged, thanks.
hangc0276
approved these changes
May 26, 2021
codelipenghui
pushed a commit
that referenced
this pull request
May 26, 2021
yangl
pushed a commit
to yangl/pulsar
that referenced
this pull request
Jun 23, 2021
…e#10695) Co-authored-by: Anonymitaet <anonymitaet_hotmail.com>
yangl
pushed a commit
to yangl/pulsar
that referenced
this pull request
Jun 23, 2021
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
…e#10695) Co-authored-by: Anonymitaet <anonymitaet_hotmail.com>
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #10638